Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing column types related to normalization_factor to decimal #1836

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Changing column types related to normalization_factor to decimal #1836

merged 2 commits into from
Apr 25, 2024

Conversation

eiffel777
Copy link
Contributor

This addresses comments on #1828 made after it was merged which include changing column types related to the normalization_factor to decimal.

Tests performed

Tested in docker

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@eiffel777 eiffel777 added Category:General General autodoc:ignore Auto documentation ignore this PR labels Apr 24, 2024
@eiffel777 eiffel777 added this to the 11.0.0 milestone Apr 24, 2024
@eiffel777 eiffel777 self-assigned this Apr 24, 2024
aestoltm
aestoltm reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@aestoltm aestoltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the su fields in configuration/etl/etl_tables.d/resource_specifications/resourcespecsfact_by_day.json also need to be updated to a decimal data type?

@aaronweeden aaronweeden mentioned this pull request Apr 24, 2024
Merged
3 tasks
aestoltm
aestoltm previously approved these changes Apr 25, 2024
View reviewed changes
@aestoltm aestoltm dismissed their stale review April 25, 2024 13:01

Comment above

@eiffel777 eiffel777 merged commit d462a86 into ubccr:xdmod11.0 Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronweeden aaronweeden aaronweeden approved these changes

@aestoltm aestoltm aestoltm left review comments

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

@ryanrath ryanrath Awaiting requested review from ryanrath

@connersaeli connersaeli Awaiting requested review from connersaeli

Assignees

@eiffel777 eiffel777

Labels
autodoc:ignore Auto documentation ignore this PR Category:General General
Projects
None yet
Milestone
11.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eiffel777 @aaronweeden @aestoltm