Add helper script that runs chromium. #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
force-pushed
the
chromium111
branch
2 times, most recently
from
a93300c
to
4fdac2c
Compare
The feature that we were previously using in chromium_headless v110 and earlier seems to have been removed in v111. This changes the code to use puppeteer-core to interact with chromium. This change is intended to be a drop in replacement: The portal_settings config that specifies the path to chromium is still used and we package the puppeteer code so no need for post install steps.
ryanrath
reviewed
Mar 28, 2023
The Centos 7 builds use the software collections feature to run the UI tests with nodejs 6. The Rocky 8 builds download node 10 and use this for the UI tests.
I've manually regression tested by running the old code, and this code in centos7 and rocky8 in three different dockers then exporting some charts. Then used an online image difference checker tool to confirm the output is the same (https://www.diffchecker.com/image-compare/)
|
ryanrath
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature that we were previously using in chromium_headless v110 and earlier seems to have been removed in v111. This changes the code to use puppeteer-core to interact with chromium.
This change is intended to be a drop in replacement: The portal_settings config that specifies the path to chromium is still used and we package the puppeteer code so no need for post install steps.