Change chromium output error detection. #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with chromium-headless-89.0.4389.82-1.el7.x86_64 chrome crashes on exit (due to the fortify stack smashing code firing). This appears to happen on exit and does not prevent chrome from rendering the svg. This change works around the problem by using the presence of valid output as the test condition and ignores the chrome exit code.
|
Note that the existing image export tests confirm that the export is actually working properly. |
ryanrath
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with chromium-headless-89.0.4389.82-1.el7.x86_64 chrome crashes on
exit (due to the fortify stack smashing code firing). This appears to happen
on exit and does not prevent chrome from rendering the svg. This change
works around the problem by using the presence of valid output as the
test condition and ignores the chrome exit code.