Use the composer autoloader to load files. #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change switches the XDMoD code to be loaded with the composer loader rather than the hybrid composer and require and custom loader. The main reason for this change is to switch the ETL directory to use a psr-4 loader thus allowing xdmod modules to extend the ETL framework. Previously it was not possible for a module to add a new DataEndpoint due to the way classes were loaded. The Appkernels module still uses the linker.json so this code path is not modified at this time. Also there was an unused file classes/DB/DBModel/TableColumn.php rather than add this to the loader path I just removed it. Also I switched on the optimizer for composer.
jpwhite4
added
the
maintenance / code quality
eiffel777
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches the XDMoD code to be loaded with the composer
loader rather than the hybrid composer and require and custom loader.
The main reason for this change is to switch the ETL directory to use
a psr-4 loader thus allowing xdmod modules to extend the ETL framework.
Previously it was not possible for a module to add a new DataEndpoint
due to the way classes were loaded.
The Appkernels module still uses the linker.json so this code path
is not modified at this time.
Also there was an unused file classes/DB/DBModel/TableColumn.php
rather than add this to the loader path I just removed it.
Also I switched on the optimizer for composer.