Update moddb.module_version table #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how MySQL handles timestamp columns this table was triggering an alter statement by the ETL system. Also updates PHP code to insert both date and time into the create_on column.
ryanrath
approved these changes
Jan 15, 2021
jtpalmer
added a commit
to jtpalmer/xdmod
that referenced
this pull request
Jan 26, 2021
Due to how MySQL handles timestamp columns this table was triggering an alter statement by the ETL system. Also updates PHP code to insert both date and time into the create_on column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
TIMESTAMPcolumns in themoddb.module_versionstable and updates PHP code to insert both date and time into thecreated_oncolumn.Due to how MySQL handles timestamp columns this table was triggering an alter statement by the ETL system. See https://github.com/ubccr/xdmod/blob/xdmod9.5/classes/ETL/DbModel/Column.php#L186 for more about how those columns are handled by the ETL system.
Motivation and Context
I noticed the table was being altered while I was debugging some role configurations. Since the
ALTERstatement doesn't do anything this will prevent it from being executed every timeacl-configis used.Tests performed
Ran
acl-config --debugthen checked forALTERstatements. Then checked contents ofmoddb.module_versions.Checklist: