Only show the New User Tour Dialog once per session. #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new user tour dialog checking-and-showing code runs every time the dashboard is loaded. The dashboard is reloaded when you navigate to it and the data have changed. I.e. multiple times per session. This change sets a flag so that the tour checking code only runs once. While investigating this issue I noticed another bug where the response data was being parsed even in the error case (which lead to a unhandled exception in the javascript). This mitigates this problem by switching the code to use the success callback function. In the error case the request will be retried the next time the dashboard loads. I saw the load failure case when using XDMoD on a noisy wi-fi connection. Fixes issue https://app.asana.com/0/808093868887967/1140113137533641
eiffel777
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new user tour dialog checking-and-showing code runs every time the
dashboard is loaded. The dashboard is reloaded when you navigate to it
and the data have changed. I.e. multiple times per session. This change
sets a flag so that the tour checking code only runs once.
While investigating this issue I noticed another bug where the response
data was being parsed even in the error case (which lead to a unhandled exception
in the javascript). This mitigates this problem by switching the
code to use the success callback function. In the error case the request
will be retried the next time the dashboard loads. I saw the load failure
case when using XDMoD on a noisy wi-fi connection.
Asana issue: https://app.asana.com/0/808093868887967/1140113137533641