Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart layout and timeframe radio button crowding #1435

Merged
merged 3 commits into from
Aug 28, 2020

Conversation

jtpalmer
Copy link
Contributor

Description

Adjust padding of chart layout and time frame radio buttons.

Before:

edit-chart-timeframe-before

After:

edit-chart-timeframe-after

Also removes trailing white space, replaces tabs with spaces, and removes commented-out CSS.

Motivation and Context

The padding fixes button crowding issues with the combination of Firefox and some Ubuntu themes.

https://app.asana.com/0/0/835282853904695/f
https://app.asana.com/0/826872005880486/827143607859035/f

Tests performed

Tested manually.

Checklist:

  • The pull request description is suitable for a Changelog entry
  • The milestone is set correctly on the pull request
  • The appropriate labels have been added to the pull request

@jtpalmer jtpalmer added bug Bugfixes Category:Report Generator Report Generator labels Aug 28, 2020
@jtpalmer jtpalmer added this to the 9.5.0 milestone Aug 28, 2020
@jtpalmer jtpalmer merged commit d16a438 into ubccr:xdmod9.5 Aug 28, 2020
@jtpalmer jtpalmer deleted the report-generator-button-crowding branch August 28, 2020 14:25
@jtpalmer jtpalmer mentioned this pull request Aug 28, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:Report Generator Report Generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants