Allow the internal dashboard to load even if a user account has an empty name. #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty name. The Internal Dashboard -> User Management -> Existing Users tab will sit spinning in "Loading" if there exists an existing user that has an empty field in any of the settings (name, email, etc). This change allows the interface to load so that an admin can actually fix the problem. Without this change the only way to fix the issue appears to be by directly modifying the contents of the database. Note that the missing name issue has been seen on metrics prod and also occurred while we were testing the XDMoD tutorial. In both cases the undelying cause was a misconfiguration, (which needed to be rectified) but this change at least allows the resultant problem to be fixed.
ryanrath
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Internal Dashboard -> User Management -> Existing Users tab will sit spinning
in "Loading" if there exists an existing user that has an empty field in any of
the settings (name, email, etc).
This change allows the interface to load so that an admin can actually fix the
problem. Without this change the only way to fix the issue appears to be by directly
modifying the contents of the database.
Note that the missing name issue has been seen on metrics prod and also occurred while
we were testing the XDMoD tutorial. In both cases the underlying cause was a misconfiguration,
(which needed to be rectified) but this change at least allows the resultant problem
to be fixed.
Tested manually in the tutorial docker build.