Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Roles and UserRole tables #1360

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

ryanrath
Copy link
Contributor

Description

We have been running for some time without actually utilizing these tables and as such
it should be safe to remove them. These changes will make sure that the tables are not
created / referenced in ETL actions as well as making sure that they are removed in
existing installations when an upgrade is performed.

Motivation and Context

An error was encountered on Prod when a User that had existed when we were using the Roles / UserRoles tables and as such had records in the UserRoles table was deleted. Since UserRoles had a FK to Users.id the User removal failed and the Internal Dashboard / Existing Users Tab was put into an unusable state as the user in question still existed in the User table but did not have any ACL's associated with it, which broke the UI code, and thus the interface.

Tests performed

All automated tests for upgrade / fresh install

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code Cleanup

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

We have been running for some time without actually utilizing these tables and as such
it should be safe to remove them. These changes will make sure that the tables are not
created / referenced in ETL actions as well as making sure that they are removed in
existing installations when an upgrade is performed.
@ryanrath ryanrath requested a review from plessbd June 29, 2020 17:10
@ryanrath ryanrath merged commit 98489a4 into ubccr:xdmod9.0 Jun 29, 2020
@jtpalmer jtpalmer changed the title Finally removing Roles / UserRole tables Remove Roles and UserRole tables Aug 10, 2020
@jtpalmer jtpalmer added this to the 9.0.0 milestone Aug 10, 2020
@jtpalmer jtpalmer added Category:General General enhancement Enhancement of the functionality of an existing feature labels Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General enhancement Enhancement of the functionality of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants