Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bug that causes stop events to create sessions #1344

Merged

Conversation

eiffel777
Copy link
Contributor

This PR fixes a bug in the CloudStateReconstructorTransformer that allowed end events such as Stop, Power Off or Shelve to start a new session. This is fixed by adding an if statement that prevents an end event from creating a new session.

A new openstack log file has been added for the regression tests. It is ingested separately to ensure we create a situation where sessions would have been incorrectly made before this change. This change means this data should not cause any new sessions to be made.

The migration script will look for sessions with end events, display the list of sessions to the user and ask if they want to remove the session. Re-aggregation of the cloud data is already necessary for upgrading to 9.0. Below is a screenshot of how this is displayed when running the upgrade.

Screenshot from 2020-06-19 08-34-48

Tests performed

Tested manually in docker and also added data to docker that would have created sessions before his issue was fixed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…signate as session end events to erroneously start a session
…t would cause stop events to create sessions
@eiffel777 eiffel777 added bug Bugfixes Category:Cloud Cloud Realm labels Jun 19, 2020
@eiffel777 eiffel777 added this to the 9.0.0 milestone Jun 19, 2020
@eiffel777 eiffel777 requested a review from plessbd June 19, 2020 12:50
@eiffel777 eiffel777 self-assigned this Jun 19, 2020
@eiffel777 eiffel777 merged commit 47f6c2b into ubccr:xdmod9.0 Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugfixes Category:Cloud Cloud Realm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants