Change default log directory permissions #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanrath
previously approved these changes
Jun 4, 2020
|
Should we also change the in the rpm post section to 660? |
plessbd
previously approved these changes
Jun 4, 2020
|
@jpwhite4 I think that makes sense. I'll change it. |
|
We might want to completely remove that block from the post section since it was intended for a specific upgrade when we originally changed those permissions (#355). |
plessbd
approved these changes
Jun 4, 2020
jpwhite4
approved these changes
Jun 4, 2020
6 tasks
jtpalmer
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the default permissions of the log directory to be
0770.Motivation and Context
This is intended to improve security.
Tests performed
Tested manually.
Types of changes
Checklist: