Add README to data warehouse export zip files #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpalmer
added
enhancement
jpwhite4
reviewed
May 1, 2020
| foreach ($fields as $field) { | ||
| $text .= sprintf( | ||
| "%s: %s\n", | ||
| $field['name'], |
There was a problem hiding this comment.
Do we allow html in the documentation field? Is it work htmldecode this before putting in the text file?
There was a problem hiding this comment.
As of now, none of the documentation fields contain html. I don't think there is anything to forbid it.
I don't see any entities, but if we do decide to allow arbitrary html then just decoding wouldn't be enough since we'd still have to strip out any tags.
jtpalmer
force-pushed
the
dwe-explanation-file
branch
from
78e5893
to
fd941e1
Compare
jpwhite4
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
README.txtfile to the data warehouse export zip file that contains a description of all the exported fields.NOTE: This depends on and includes all the commits from #1298 as of nowMotivation and Context
https://app.asana.com/0/15230011293693/1146676887787308
Tests performed
Updated automated tests. Tested manually.
Types of changes
Checklist: