Fixes/enhancements found when testing multihost aggregation #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smgallo
added
bug
…tihost-aggregation
|
Note that this code introduces 8 new problems (7 errors) (1 warning). |
|
@jpwhite4 can you provide the command you're using to check for errors? |
|
Click on "show all checks" then look at the logs for "test suite = style". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and enhancements implemented during testing of multihost aggregation (jobs tables on one mysql server and aggregation tables on another server).
Description
Bug fixes and support for specifying STRAIGHT_JOIN in a query.
Motivation and Context
We don't like bugs or slow queries.
Tests performed
Performed aggregation from with job records on tas-db1 and aggregated jobs in a local VM database. Also tested with and without batch aggregation.
./etl_overseer.php -c ../../../etc/etl/etl.json -a XdcdbJobRecordAggregatorTest -f -s 2016-12-01 -e 2016-12-23 -v debug ./etl_overseer.php -c ../../../etc/etl/etl.json -a XdcdbJobRecordAggregatorTest -f -s 2016-12-01 -e 2016-12-23 -v debug -o "experimental_enable_batch_aggregation=true"Types of changes
Checklist: