Enforce realm ACLs for "show raw data" endpoints #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, even though the raw data was protected by ACLs the list of realms was not. So a user could see all realms that supported raw data access (even if they did not have permission to see the realm itself). This scenario is not seen in the default open xdmod installs since all uses have access to jobs and supremm realms. This is seen in the XSEDE version where different roles have different realm access. Also add the capabilty to disable a realm from raw data access via the config file.
jpwhite4
force-pushed
the
enforce_rawdata_acl
branch
from
c06c855
to
0943e10
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
jtpalmer
approved these changes
Jan 14, 2020
jtpalmer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, even though the raw data was protected by ACLs the list of
realms was not. So a user could see all realms that supported raw data
access (even if they did not have permission to see the realm itself).
This scenario is not seen in the default open xdmod installs since all
uses have access to jobs and supremm realms. This is seen in the XSEDE
version where different roles have different realm access.
Also add the capabilty to disable a realm from raw data access via the
config file.