Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable cors #1193

Closed
wants to merge 6 commits into from
Closed

enable cors #1193

wants to merge 6 commits into from

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Dec 17, 2019 •
edited
Loading

Enable the ability for an admin to enable cors allowed domains

DO NOT MERGE this is for a specific release and might have its base changed.

@plessbd plessbd mentioned this pull request Dec 23, 2019
Closed
jtpalmer
jtpalmer suggested changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@jtpalmer jtpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a route that matches anything may have unpredictable consequences. The whole team should discuss this before merging.

@plessbd plessbd closed this Jan 2, 2020
@plessbd plessbd reopened this Jan 2, 2020
@plessbd plessbd requested a review from jtpalmer January 14, 2020 17:38
jtpalmer
jtpalmer reviewed Jan 14, 2020
View reviewed changes
classes/Rest/XdmodApplicationFactory.php Outdated Show resolved Hide resolved
classes/Rest/XdmodApplicationFactory.php Outdated Show resolved Hide resolved
plessbd and others added 2 commits January 14, 2020 14:43
@plessbd plessbd added enhancement Enhancement of the functionality of an existing feature Open OnDemand Specific changes for Open OnDemand Integration labels Jan 15, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@plessbd
Copy link
Contributor Author

plessbd commented Jan 16, 2020 •
edited
Loading

Replaced by #1207

@plessbd plessbd closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpalmer jtpalmer jtpalmer requested changes

@chakrabortyr chakrabortyr chakrabortyr left review comments

@jpwhite4 jpwhite4 jpwhite4 left review comments

Assignees
No one assigned
Labels
enhancement Enhancement of the functionality of an existing feature Open OnDemand Specific changes for Open OnDemand Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plessbd @jtpalmer @chakrabortyr @jpwhite4