Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storage realm username GroupBy #1156

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Fix storage realm username GroupBy #1156

merged 1 commit into from
Nov 27, 2019

Conversation

jtpalmer
Copy link
Contributor

@jtpalmer jtpalmer commented Nov 6, 2019

Description

Fixes the storage realm GroupByUsername class.

Motivation and Context

This bug breaks the system username filter.

Tests performed

Tested manually.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtpalmer jtpalmer added bug Bugfixes Category:Storage Storage labels Nov 6, 2019
@jtpalmer jtpalmer added this to the 9.0.0 milestone Nov 6, 2019
@jtpalmer jtpalmer removed the request for review from chakrabortyr November 26, 2019 19:35
@jtpalmer jtpalmer merged commit 89853f1 into ubccr:xdmod9.0 Nov 27, 2019
@jtpalmer jtpalmer deleted the fix-storage-group-by-username branch November 27, 2019 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plessbd plessbd plessbd approved these changes

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

@jsperhac jsperhac Awaiting requested review from jsperhac

Assignees
No one assigned
Labels
bug Bugfixes Category:Storage Storage
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jtpalmer @plessbd