Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JSON references to overwrite keys #1142

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Allow JSON references to overwrite keys #1142

merged 1 commit into from
Dec 4, 2019

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Oct 31, 2019 •
edited
Loading

added to feature/groupby-refactor but not exclusively related
see #1078 for more details

@smgallo @plessbd
Extend JSON references to allow adding and/or overwriting of ke… (ubc…
d6db114 
…cr#1078)

* Add support for adding/overwriting keys in a JSON reference

* Add tests
@jpwhite4 jpwhite4 added this to the 9.0.0 milestone Oct 31, 2019
@plessbd plessbd added Category:General General new feature New functionality labels Nov 1, 2019
@jtpalmer jtpalmer changed the title Extend JSON references to allow adding and/or overwriting of ke… (#1078) Extend JSON references to allow adding and/or overwriting of … Nov 4, 2019
@plessbd plessbd changed the title Extend JSON references to allow adding and/or overwriting of … Allow JSON references to overwrite keys Nov 4, 2019
@plessbd plessbd merged commit 49c5b0a into ubccr:xdmod9.0 Dec 4, 2019
@plessbd plessbd deleted the ref-with-override-support branch December 4, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanrath ryanrath ryanrath approved these changes

@jpwhite4 jpwhite4 Awaiting requested review from jpwhite4

@jtpalmer jtpalmer Awaiting requested review from jtpalmer

Assignees
No one assigned
Labels
Category:General General new feature New functionality
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@plessbd @ryanrath @jpwhite4 @smgallo