Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update statistics and groupbys for consistency #1089

Merged
merged 4 commits into from
Oct 25, 2019
Merged

Update statistics and groupbys for consistency #1089

merged 4 commits into from
Oct 25, 2019

Conversation

plessbd
Copy link
Contributor

@plessbd plessbd commented Oct 3, 2019 •
edited by jpwhite4
Loading

https://app.asana.com/0/search/1145139272034946/1145139272034947

Description

The group bys and statistics are not consistent between realms, this updates them a bit to do that

Motivation and Context

consistency is good

Tests performed

all of them

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@plessbd plessbd requested a review from jpwhite4 October 3, 2019 15:34
@plessbd plessbd changed the base branch from xdmod8.6 to xdmod8.5 October 3, 2019 17:07
@plessbd plessbd force-pushed the consistency-ftw branch 3 times, most recently from 3867540 to c0ba06c Compare October 3, 2019 18:40
@jpwhite4 jpwhite4 added this to the 8.6.0 milestone Oct 4, 2019
@plessbd plessbd changed the base branch from xdmod8.5 to xdmod8.6 October 7, 2019 12:09
@jpwhite4
Copy link
Member

https://app.asana.com/0/search/1145139272034946/1145139272034947

@jpwhite4 jpwhite4 modified the milestones: 8.6.0, 9.0.0 Oct 23, 2019
@jtpalmer jtpalmer changed the base branch from xdmod8.6 to xdmod9.0 October 23, 2019 16:50
@plessbd plessbd added Category:General General data quality Data quality issues such as improvements to sql queries to improve precision or consistency labels Oct 25, 2019
@plessbd plessbd merged commit fe4b7e9 into ubccr:xdmod9.0 Oct 25, 2019
@plessbd plessbd deleted the consistency-ftw branch October 25, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpwhite4 jpwhite4 jpwhite4 approved these changes

Assignees
No one assigned
Labels
Category:General General data quality Data quality issues such as improvements to sql queries to improve precision or consistency
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@plessbd @jpwhite4