Fixing an infinite loop when discarding user changes #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There was a problem when the user settings ( User Type, Map To, Institution etc. ) were updated but the changes discarded. This was caused by these elements not being reset to their original values. That function has been added. - Tests have also been added so that we can be sure this behavior doesn't crop up again.
jtpalmer
approved these changes
Sep 26, 2019
smgallo
pushed a commit
to smgallo/xdmod
that referenced
this pull request
Oct 1, 2019
- There was a problem when the user settings ( User Type, Map To, Institution etc. ) were updated but the changes discarded. This was caused by these elements not being reset to their original values. That function has been added. - Tests have also been added so that we can be sure this behavior doesn't crop up again.
smgallo
added a commit
that referenced
this pull request
Oct 1, 2019
* Bug fixes: Add mask and make chart name unique * Refresh clears the search field * Check for alternate timezone field (#1061) * Data warehouse export tests and bug fix (#1063) * Fix dry run behavior * Add data warehouse export tests * Add Usage Explorer Tests (#1062) * Add Usage Tests for disabled Display Menu Items * Document required file name extension (#1066) * Fixing an infinite loop when discarding user changes (#1068) * Replace previous year with year to date * Ensure Jobs realm data access class provides required fields * Force refresh dashboard tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
etc. ) were updated but the changes discarded. This was caused by these
elements not being reset to their original values. That function has been
added.
up again.
Motivation and Context
infinite loop bad
Tests performed
Manual Testing was performed along with the addition of automated tests to catch this problem in the future.
Types of changes
Checklist: