Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi realm installs - Allow for modification of enabled realms… #1004

Merged
merged 5 commits into from
Aug 16, 2019
Merged

Multi realm installs - Allow for modification of enabled realms… #1004

merged 5 commits into from
Aug 16, 2019

Conversation

tpetrus
Copy link
Contributor

@tpetrus tpetrus commented Aug 14, 2019

Integrate selection of desired realms to be enabled in XDMoD instance and allow all tests to pass based on which realms are enabled.

Description

  • Environment variable XDMOD_REALMS now used to set desired realms in a comma-separated string style
  • Modified bootstrap among other files to only ingest proper items required for the realms desired
  • Made Job Viewer tab disabled if the jobs realm isn't enabled, and suppressed error messages corresponding to JobViewer not finding the jobs realm (if it's not enabled)
  • Updated all tests to properly work with whatever combination of realms that are enabled (This included splitting up the proper test artifacts by realm)

Motivation and Context

It allows for the selection of realms to be enabled, where before there was no way to do so.

Tests performed

I ran all tests on every single combination (and order) of Jobs, Cloud, and Storage realms possible, using both the fresh_install and upgrade test modes, and all on fresh XDMoD instances.

I ran the same script commands that Shippable currently runs to do its tests of XDMoD. This included setting up a new XDMoD instance with the desired realms, and running regression, integration, component, UI, and all SSO tests on that instance.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tests/ci/bootstrap.sh Outdated Show resolved Hide resolved
@plessbd plessbd added the Category:General General label Aug 16, 2019
@plessbd plessbd added the qa / testing Updates/additions to tests label Aug 16, 2019
@plessbd plessbd changed the title Multi realm installs - Allow for modification of enabled realms with all tests passing Multi realm installs - Allow for modification of enabled realms… Aug 16, 2019
@plessbd plessbd merged commit 41849f9 into ubccr:xdmod8.5 Aug 16, 2019
@plessbd plessbd added this to the 8.5.0 milestone Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:General General qa / testing Updates/additions to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants