Fixing misnamed variable (#1875)

This variable referenced one that did not exist, this would have caused a runtime error if called.
ubccr · Jun 26, 2024 · 3964cb3 · 3964cb3
1 parent bad40a7
commit 3964cb3
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/classes/DB/PDODBMultiIngestor.php b/classes/DB/PDODBMultiIngestor.php
@@ -452,7 +452,7 @@ protected function getCommonProcessingStatements($configFilePath)
     protected function loadProcessingConfig($configFilePath)
     {
         if (! is_file($configFilePath)) {
-            throw new Exception("'$configPath' is missing. If no processing is needed, use an empty array.");
+            throw new Exception("'$configFilePath' is missing. If no processing is needed, use an empty array.");
         }
 
         $configFileContents = @file_get_contents($configFilePath);

diff --git a/classes/DataWarehouse/Query/ResourceSpecifications/RawData.php b/classes/DataWarehouse/Query/ResourceSpecifications/RawData.php
@@ -23,7 +23,8 @@ public function __construct(
         $endDate,
         $groupById = null,
         $statisticId = null,
-        array $parameters = array()
+        array $parameters = array(),
+        LoggerInterface $logger = null
     ) {
         $realmId = 'ResourceSpecifications';
         $schema = 'modw_aggregates';
@@ -36,7 +37,8 @@ public function __construct(
             $endDate,
             $groupById,
             $statisticId,
-            $parameters
+            $parameters,
+            $logger
         );
 
         $this->setDistinct(true);

diff --git a/classes/OpenXdmod/Shredder/Pbs.php b/classes/OpenXdmod/Shredder/Pbs.php
@@ -337,7 +337,7 @@ public function getJobId($id)
         } elseif (preg_match('/^\d+$/', $sequence, $matches)) {
             $jobId = $sequence;
         } else {
-            $this->logger->warning("Unknown id_string format: '$id_string'");
+            $this->logger->warning("Unknown id_string format: '$id'");
             $jobId = $sequence;
         }
 

diff --git a/classes/Rest/Controllers/MetricExplorerControllerProvider.php b/classes/Rest/Controllers/MetricExplorerControllerProvider.php
@@ -96,7 +96,7 @@ public function getQueries(Request $request, Application $app)
                 $payload['success'] = true;
                 $statusCode = 200;
             } else {
-                $payload['message'] = self::_DEFAULT_ERROR_MESSAGE;
+                $payload['message'] = self::EXCEPTION_MESSAGE;
             }
         } catch (BadRequestHttpException $e) {
             $payload['message'] = $e->getMessage();
@@ -149,7 +149,7 @@ public function getQueryById(Request $request, Application $app, $id)
                     $statusCode = 404;
                 }
             } else {
-                $payload['message'] = self::_DEFAULT_ERROR_MESSAGE;
+                $payload['message'] = self::EXCEPTION_MESSAGE;
             }
         } catch (BadRequestHttpException $e) {
             $payload['message'] = $e->getMessage();
@@ -202,7 +202,7 @@ public function createQuery(Request $request, Application $app)
                     $statusCode = 500;
                 }
             } else {
-                $payload['message'] = self::_DEFAULT_ERROR_MESSAGE;
+                $payload['message'] = self::EXCEPTION_MESSAGE;
             }
         } catch (BadRequestHttpException $e) {
             $payload['message'] = $e->getMessage();
@@ -290,7 +290,7 @@ public function updateQueryById(Request $request, Application $app, $id)
                     $statusCode = 404;
                 }
             } else {
-                $payload['message'] = self::_DEFAULT_ERROR_MESSAGE;
+                $payload['message'] = self::EXCEPTION_MESSAGE;
             }
         } catch (BadRequestHttpException $e) {
             $payload['message'] = $e->getMessage();
@@ -351,7 +351,7 @@ public function deleteQueryById(Request $request, Application $app, $id)
                     $statusCode = 404;
                 }
             } else {
-                $payload['message'] = self::_DEFAULT_ERROR_MESSAGE;
+                $payload['message'] = self::EXCEPTION_MESSAGE;
             }
         } catch (BadRequestHttpException $e) {
             $payload['message'] = $e->getMessage();