Skip to content

Commit

Permalink
Reverting constructor argument refactor
Browse files Browse the repository at this point in the history
per code review by @jpwhite I'm changing the constructor arguments to
their original location and just changing the
`$pre_ingest_update_statements` to not have a default value. This has
been accounted for in it's usage in `Shredder.php`.
  • Loading branch information
spark0r committed May 16, 2024
1 parent 9380376 commit 1e63e8e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion classes/DB/PDODBMultiIngestor.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ class PDODBMultiIngestor implements Ingestor
function __construct(
$dest_db,
$source_db,
$pre_ingest_update_statements,
$source_query,
$insert_table,
$pre_ingest_update_statements = array(),
$insert_fields = array(),
$post_ingest_update_statements = array(),
$delete_statement = null,
Expand Down
4 changes: 2 additions & 2 deletions classes/DB/PDODBUnbufferedMultiIngestor.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ class PDODBUnbufferedMultiIngestor Extends PDODBMultiIngestor
public function __construct(
PDODB $dest_db,
PDODB $source_db,
array $pre_ingest_update_statements = array(),
array $pre_ingest_update_statements,
$source_query,
$insert_table,
array $insert_fields = array(),
Expand Down Expand Up @@ -40,9 +40,9 @@ public function __construct(
parent::__construct(
$dest_db,
$source_db,
$pre_ingest_update_statements,
$source_query,
$insert_table,
$pre_ingest_update_statements,
$insert_fields,
$post_ingest_update_statements,
$delete_statement,
Expand Down
2 changes: 1 addition & 1 deletion classes/OpenXdmod/Shredder.php
Original file line number Diff line number Diff line change
Expand Up @@ -563,9 +563,9 @@ public function getJobIngestor($ingestAll = false)
$ingestor = new PDODBMultiIngestor(
$this->db,
$this->db,
array(),
$sourceQuery,
'shredded_job',
array(),
$insertFields,
array(),
$deleteStatement
Expand Down

0 comments on commit 1e63e8e

Please sign in to comment.