Merge pull request #1349 from jpwhite4/factDIM

Fix bugs in definition of job fact tables.
ubccr · Jun 25, 2020 · 0486f22 · 0486f22
2 parents 85389ab + 77e9b2d
commit 0486f22
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_.json
@@ -157,8 +157,8 @@
             {
                 "name": "processorbucket_id",
                 "type": "int(4)",
-                "comment": "FACT: Pre-determined processor bucket sizes. References processorbucket.id",
-                "nullable": true
+                "comment": "DIMENSION: Pre-determined processor bucket sizes. References processor_buckets.id",
+                "nullable": false
             },
             {
                 "name": "gpu_count",
@@ -169,7 +169,7 @@
             {
                 "name": "gpubucket_id",
                 "type": "int(11)",
-                "nullable": true,
+                "nullable": false,
                 "comment": "DIMENSION: Pre-determined GPU bucket sizes. References gpu_buckets.id"
             },
             {

diff --git a/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json b/configuration/etl/etl_tables.d/jobs/xdw/jobfact_by_day.json
@@ -163,8 +163,8 @@
             {
                 "name": "processorbucket_id",
                 "type": "int(4)",
-                "comment": "FACT: Pre-determined processor bucket sizes. References processorbucket.id",
-                "nullable": true
+                "comment": "DIMENSION: Pre-determined processor bucket sizes. References processor_buckets.id",
+                "nullable": false
             },
             {
                 "name": "gpu_count",
@@ -175,7 +175,7 @@
             {
                 "name": "gpubucket_id",
                 "type": "int(11)",
-                "nullable": true,
+                "nullable": false,
                 "comment": "DIMENSION: Pre-determined GPU bucket sizes. References gpu_buckets.id"
             },
             {