Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockersplit #388

Open
wants to merge 8 commits into
base: xdmod11.0
Choose a base branch
from
Open

Dockersplit #388

wants to merge 8 commits into from

Conversation

ShixinWu16
Copy link

Description

Changes to support XDMoD database on an external host

Added a question to get XDMoD host and connect to the correct mongodb

  • classes/OpenXdmod/Setup/SupremmDbSetup.php
  • tests/integration/scripts/xdmod-setup.tcl

Changed test case to look for the correct phpunit

  • tests/unit/runtests.sh

Motivation and Context

We wanted to split up the docker containers so that each module has their own container.
This would allow us to share our docker images without having to share everything.

Tests performed

Ran all automated tests, changed unit test so that it uses the correct phpunit

Types of changes

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • [ X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ X ] My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ X ] All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants