Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the paths to the XML test results in the CircleCI config. Some of the paths were set to
/tmp/phpunit
, and some were set to~/phpunit
. As a result, the directory/tmp/phpunit
was created, but the test results were written to~/phpunit
, which was assumed to be a file rather than a directory, and then CircleCI stored/tmp/phpunit
, which was empty. This PR sets all of the paths to~/phpunit
rather than/tmp/phpunit
to be consistent with the CircleCI config of thexdmod
repository. It also gives filenames to each of the tests that use--log-junit
so that the results are saved to files rather than being output to the terminal.Tests performed
I checked the
build-fresh_install-rocky8
andbuild-upgrade-rocky8
checks to make sure the test results show up in the "TESTS" tab, that each of the CircleCI steps that write to~/phpunit
do not list any errors, and that the "Uploading test results" step archives the following test results:Types of changes
Checklist: