Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCI test result paths. #367

Merged

Conversation

aaronweeden
Copy link
Contributor

@aaronweeden aaronweeden commented Dec 5, 2023

Description

This PR fixes the paths to the XML test results in the CircleCI config. Some of the paths were set to /tmp/phpunit, and some were set to ~/phpunit. As a result, the directory /tmp/phpunit was created, but the test results were written to ~/phpunit, which was assumed to be a file rather than a directory, and then CircleCI stored /tmp/phpunit, which was empty. This PR sets all of the paths to ~/phpunit rather than /tmp/phpunit to be consistent with the CircleCI config of the xdmod repository. It also gives filenames to each of the tests that use --log-junit so that the results are saved to files rather than being output to the terminal.

Tests performed

I checked the build-fresh_install-rocky8 and build-upgrade-rocky8 checks to make sure the test results show up in the "TESTS" tab, that each of the CircleCI steps that write to ~/phpunit do not list any errors, and that the "Uploading test results" step archives the following test results:

* /root/phpunit/component.xml
* /root/phpunit/integration.xml
* /root/phpunit/xdmod-supremm-regression-centerdirector.xml
* /root/phpunit/xdmod-ui.xml

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronweeden aaronweeden added the bug label Dec 5, 2023
@aaronweeden aaronweeden added this to the 11.0.0 milestone Dec 5, 2023
@aaronweeden aaronweeden marked this pull request as draft December 5, 2023 15:14
@aaronweeden aaronweeden changed the title Fix CircleCI test results path. Fix CircleCI test result paths. Dec 5, 2023
@aaronweeden aaronweeden marked this pull request as ready for review December 5, 2023 16:26
@aaronweeden aaronweeden merged commit 1371aa0 into ubccr:xdmod11.0 Dec 5, 2023
3 checks passed
@aaronweeden aaronweeden deleted the fix-circleci-test-results-path branch December 5, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants