Refactor and add integration tests of invalid REST parameters. #350
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors some of the integration tests and adds new ones that test the validation of REST parameters that are obtained via the
getParam()
method ofBaseControllerProvider
.Tests performed
I developed the tests incrementally while running in the
tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.0.0:rockylinux8-0.1
Docker container upgraded to the branch ofxdmod
from ubccr/xdmod#1768.Also, in a Docker container running
tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.5.0:rockylinux8-0.1
:/unit-{before,after}.txt
and make sure the only difference is the amount of time the tests ran./component-{before,after}.txt
and make sure the only difference is the amount of time the tests ran./regression-{before,after}.txt
and make sure the only differences are randomized parameters, amount of time the tests ran, and possibly transient "other notices" related to small differences in column values./integration-{before-edited,after}.txt
and make sure the differences are correct:IntegrationTests\REST\EfficiencyTest::testCPUUsageScatterPlotEndpointMalformedRequest
.IntegrationTests\REST\EfficiencyTest::testCPUUsageDrillownEndpointMalformedRequest
.IntegrationTests\REST\EfficiencyTest::testGetHistogramDataParamValidation
.IntegrationTests\REST\SupremmDataflowControllerProviderTest::testGetDbst
IntegrationTests\REST\SupremmDataflowControllerProviderTest::testGetQuality
.Types of changes
Checklist: