Refactor and add integration tests of invalid REST parameters.

[aaronweeden]

Description

This PR refactors some of the integration tests and adds new ones that test the validation of REST parameters that are obtained via the getParam() method of BaseControllerProvider.

Tests performed

I developed the tests incrementally while running in the tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.0.0:rockylinux8-0.1 Docker container upgraded to the branch of xdmod from ubccr/xdmod#1768.

Also, in a Docker container running tools-ext-01.ccr.xdmod.org/xdmod-job_performance-10.5.0:rockylinux8-0.1:

1. Run the following commands:

   export COMPOSER_ALLOW_SUPERUSER=1
   export XDMOD_REALMS='jobs,storage,cloud,supremm,jobefficiency'
   export XDMOD_IS_CORE=yes
   export XDMOD_INSTALL_DIR=/xdmod
   export XDMOD_TEST_MODE=upgrade
   export XDMOD_SRC_DIR=./../xdmod
   git clone https://github.com/aaronweeden/xdmod-supremm -b php-error-log /xdmod-supremm
   dnf module -y reset nodejs
   dnf module -y install nodejs:16
   git clone https://github.com/ubccr/xdmod $XDMOD_SRC_DIR
   cd /xdmod-supremm
   ln -s `pwd` $XDMOD_SRC_DIR/open_xdmod/modules/supremm
   ./tests/ci/scripts/install_mongo.sh
   composer install --no-progress
   composer config -g cache-files-ttl 315360000
   composer install -d $XDMOD_SRC_DIR --no-progress
   mkdir -p ~/phpunit
   mkdir -p /tmp/screenshots
   export XDMOD_SOURCE_DIR=/xdmod
   export SHIPPABLE_BUILD_DIR=/xdmod-supremm
   pushd $XDMOD_SRC_DIR
   ~/bin/buildrpm xdmod supremm
   popd
   ./tests/integration/scripts/bootstrap.sh
   ./tests/integration/scripts/validate.sh
   composer install -d $XDMOD_SRC_DIR --no-progress
   composer install --no-progress
   ./tests/ci/scripts/qa-test-setup.sh
   export XDMOD_INSTALL_DIR=/usr/share/xdmod
   ./tests/ci/scripts/post-install-test.sh
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/component/runtests.sh
   ./tests/component/runtests.sh > /component-before.txt
   composer install -d $XDMOD_SRC_DIR --no-progress
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/integration/runtests.sh
   ./tests/integration/runtests.sh > /integration-before.txt
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/regression/runtests.sh
   ./tests/regression/runtests.sh > /regression-before.txt
   ./tests/artifacts/update-artifacts.sh
   cd tests/unit/
   ../../vendor/bin/phpunit --debug . > /unit-before.txt
   cd /xdmod-supremm
   git clone https://github.com/aaronweeden/xdmod-supremm -b fix-rest-array-param-validation /xdmod-supremm-new
   unalias rm
   rm -r /xdmod-supremm/tests
   cp -r /xdmod-supremm{-new,}/tests
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/component/runtests.sh
   ./tests/component/runtests.sh > /component-after.txt
   composer install -d $XDMOD_SRC_DIR --no-progress
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/integration/runtests.sh
   ./tests/integration/runtests.sh > /integration-after.txt
   sed -i 's/\$phpunit /$phpunit --debug /' ./tests/regression/runtests.sh
   ./tests/regression/runtests.sh > /regression-after.txt
   ./tests/artifacts/update-artifacts.sh
   cd tests/unit/
   ../../vendor/bin/phpunit --debug . > /unit-after.txt
   cd /xdmod-supremm
   sed 's/IntegrationTests\\REST\\Efficiency\\EfficiencyTest/IntegrationTests\\REST\\EfficiencyTest/g' /integration-before.txt  | sed 's/IntegrationTests\\REST\\SupremmDataflow\\QualityTest::testQuality/IntegrationTests\\REST\\SupremmDataflowControllerProviderTest::testGetQuality/g' > /integration-before-edited.txt
   

2. Compare /unit-{before,after}.txt and make sure the only difference is the amount of time the tests ran.
3. Compare /component-{before,after}.txt and make sure the only difference is the amount of time the tests ran.
4. Compare /regression-{before,after}.txt and make sure the only differences are randomized parameters, amount of time the tests ran, and possibly transient "other notices" related to small differences in column values.
5. Compare /integration-{before-edited,after}.txt and make sure the differences are correct:
   1. Different parameters and 14 additional tests for IntegrationTests\REST\EfficiencyTest::testCPUUsageScatterPlotEndpointMalformedRequest.
   2. 3 fewer tests for IntegrationTests\REST\EfficiencyTest::testCPUUsageDrillownEndpointMalformedRequest.
   3. 4 additional tests for IntegrationTests\REST\EfficiencyTest::testGetHistogramDataParamValidation.
   4. 8 additional tests for IntegrationTests\REST\SupremmDataflowControllerProviderTest::testGetDbst
   5. Different parameters and 3 additional tests for IntegrationTests\REST\SupremmDataflowControllerProviderTest::testGetQuality.
   6. 103 tests -> 129 tests, 475 assertions -> 616 assertions.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project as found in the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.