Style: Removed ESLint rule prohibiting for...in statements #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the ESLint rule prohibiting
for...instatements in JavaScript code.If accepted, similar pull requests will be opened for other XDMoD repos.
Motivation and Context
Use of
for...inwith proper precautions (e.g. checking for prototype properties, not using it on objects with deep prototype chains where performance matters) results in code that is easier to write and read than alternative methods.Tests Performed
Verified that ESLint still worked with the new config file.
Checklist:
I have added tests to cover my changes.