Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SUPReMM Dataflow REST Endpoint #335

Merged
merged 4 commits into from
Aug 18, 2022

Conversation

thanickcruz
Copy link
Contributor

Description

  • Modified query strings to return info on available jobs and total jobs together, rather than the percentage.
  • Removed hardcoded columns in GPU query

Motivation and Context

  • The precise values for available and total jobs conveys more information than just percentage.
  • Hardcoded columns in GPU query only applied to CCR systems, had to remove them for generality.

Tests performed

Tested various date ranges on every type on my metrics-dev port to make sure response was valid.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

No longer calculates rounded percent, now returns numerator and denominator to convey more info.
@jpwhite4 jpwhite4 merged commit 5a8d340 into ubccr:xdmod10.5 Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants