Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different endpoint for filter values on efficiency tab filter store freeform search. #325

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

hltaylor26
Copy link
Contributor

Description

The current filter store for the filter freeform search in the efficiency tab uses the metric explorer endpoint to get the dimension values. This endpoint defaults to 20 if no limit is set in the base params. There is a separate endpoint that exists and is used by the job viewer that has the same functionality but allows for no limit to be set and defaults to null resulting in all values being returned.

There was an issue that came up in the XSEDE10.0 release that not all PI filters were autocompleting when you started typing in the search box because the limit was not high enough. My suggested change for 10.5 is to switch to using the other endpoint and not set a limit, so that all values possible will be returned and the autocomplete search will work properly. The other option is to hardcode the limit, but we have already seen issues with that (as could be seen in the XSEDE10.0 testing).

Motivation and Context

Fixes the issue: https://app.asana.com/0/1201929110850019/1202109495471984/f

Tests performed

Tested this change on metrics-dev on my port.
https://metrics-dev.ccr.buffalo.edu:9001/#main_tab_panel:efficiency

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@hltaylor26 hltaylor26 added the bug label Apr 13, 2022
@hltaylor26 hltaylor26 added this to the 10.5.0 milestone Apr 13, 2022
@jpwhite4 jpwhite4 changed the base branch from xdmod10.5 to xdmod11.0 November 16, 2023 15:50
@jpwhite4 jpwhite4 merged commit f7f6955 into ubccr:xdmod11.0 Nov 16, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants