Use different endpoint for filter values on efficiency tab filter store freeform search. #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current filter store for the filter freeform search in the efficiency tab uses the metric explorer endpoint to get the dimension values. This endpoint defaults to 20 if no limit is set in the base params. There is a separate endpoint that exists and is used by the job viewer that has the same functionality but allows for no limit to be set and defaults to null resulting in all values being returned.
There was an issue that came up in the XSEDE10.0 release that not all PI filters were autocompleting when you started typing in the search box because the limit was not high enough. My suggested change for 10.5 is to switch to using the other endpoint and not set a limit, so that all values possible will be returned and the autocomplete search will work properly. The other option is to hardcode the limit, but we have already seen issues with that (as could be seen in the XSEDE10.0 testing).
Motivation and Context
Fixes the issue: https://app.asana.com/0/1201929110850019/1202109495471984/f
Tests performed
Tested this change on metrics-dev on my port.
https://metrics-dev.ccr.buffalo.edu:9001/#main_tab_panel:efficiency
Types of changes
Checklist: