Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppKernel: modify xdmod source for php7 compatibility #18

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

jsperhac
Copy link
Contributor

@jsperhac jsperhac commented Apr 20, 2017

Description

Fixed up xdmod core source based on the output of php7cc version compatibility checker (https://github.com/sstalle/php7cc). This provided an opportunity to delete some woefully dated source code that used deprecated syntax and packages.

Refer to pull requests against ubccr/xdmod#101 and https://github.com/ubccr/xdmod-xsede/pull/29 repos for associated changes for php7 compatibility.

As spelled out in the original commit remarks:

  • Renamed an AppKernel namespace class from Resource to AKResource

Motivation and Context

This PR helps prepare xdmod for a migration to a newer PHP version, and provides the opportunity to prune some unused and outdated code.

Tests performed

All existing integration and unit tests were run without incident. Where coverage is limited (e.g. user profile), manual testing was done to (hopefully) ensure no behavioral changes were introduced.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jsperhac jsperhac added this to the v6.7.0 milestone Apr 20, 2017
@jsperhac jsperhac merged commit b47565c into ubccr:xdmod6.7 Apr 20, 2017
@jsperhac jsperhac deleted the php7-xdmod branch April 20, 2017 20:15
jtpalmer added a commit that referenced this pull request May 15, 2017
@tyearke tyearke modified the milestones: v7.0.0, v6.7.0 Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants