Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert old rest stack: appkernels module #12

Merged
merged 1 commit into from
Apr 11, 2017

Conversation

jsperhac
Copy link
Contributor

@jsperhac jsperhac commented Mar 22, 2017

This is a step along the way toward killing off the old REST stack.

Description

Convert internal dashboard application kernel functionality to call the NewRest rest stack endpoint. Then, remove source code from the old classes/REST/akrr rest stack. This is a tidier implementation of my old pull request #422 from the xdmod-private ccr repo.

Refer to pull requests against

Motivation and Context

  • Head in the direction of reducing 3 rest stacks to 2 rest stacks
  • I'm tired of dead, duplicated, unused code.

Tests performed

Front-end was tested in grotesque detail by submitter and by Bob, in November 2016.

Changes are limited to effecting the internal dashboard, namely, to the code that populates drop-down menus for resources and kernels in the Walltime and Schedule areas. These were tested by hand to verify, using chrome debugger to observe which rest endpoints are in use. Finally, tests for the endpoints effected here have been added and use the integration test harness.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project as found in the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Caveats:

More things I'd like to do related to the rest stacks:

  • Introduce improved logging for the NewRest controllers

To Do:

Remaining to do in this exercise:

  • see pull requests named "convert-old-rest-stack" for supremm and base xdmod modules.

@plessbd
Copy link
Contributor

plessbd commented Mar 23, 2017

As long as this works, LGTM

public function testKernelNullParam()
{
$data = $this->validateAkrrKernelEntries(null);
$this->assertGreaterThanOrEqual(1, $data);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work? $data is an array and we are asserting that it is >= 1

@jsperhac jsperhac merged commit 23b3a5e into ubccr:xdmod6.6 Apr 11, 2017
@tyearke tyearke added this to the v6.6.0 milestone Apr 12, 2017
@tyearke tyearke added the qa label Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants