Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous config issues fixed #417

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Conversation

rg663
Copy link
Collaborator

@rg663 rg663 commented Jun 24, 2022

Resolves #414

Now, the following occur:

  • the Help button on the navbar only appears when the user specifies the center's help URL, otherwise is not present
  • when removing a user from an allocation or a project, the alert reads "removed 1 user" instead of "removed 1 users"
  • the default center name is HPC Center to avoid redundancies in parts of the website

Tested through:

  • specifying a center help URL and seeing the button appear, and not specifying one and seeing the navbar without the button
  • removing a user from both a project and an allocation and reading the alert
  • checking the default center name in config settings and in parts of the frontend, such as when requesting an allocation

@aebruno aebruno added the needs review Waiting for review label Jul 6, 2022
@aebruno aebruno requested a review from dsajdak July 6, 2022 13:34
@aebruno aebruno merged commit b345846 into ubccr:master Jul 6, 2022
@aebruno aebruno removed the needs review Waiting for review label Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix miscellaneous config issues
2 participants