Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a struct for rpc result type #7

Closed
uatuko opened this issue Dec 15, 2023 · 0 comments · Fixed by #8
Closed

Use a struct for rpc result type #7

uatuko opened this issue Dec 15, 2023 · 0 comments · Fixed by #8
Assignees
@uatuko
Labels
enhancement New feature or request

Comments

@uatuko
Copy link
Owner

uatuko commented Dec 15, 2023

rpc::result_type is defined as a std::pair.

grpcxx/lib/grpcxx/rpc.h

Line 19 in 0cf174e

using result_type = std::pair<status, optional_response_type>;

This works but .first and .second members don't mean much. It would be better to use a struct instead.
@uatuko uatuko added the enhancement New feature or request label Dec 15, 2023
@uatuko uatuko self-assigned this Dec 15, 2023
uatuko added a commit that referenced this issue Dec 15, 2023
@uatuko
(grpcxx) #7 - use a struct for rpc result type
965ce05
@uatuko uatuko mentioned this issue Dec 15, 2023
Merged
uatuko added a commit that referenced this issue Dec 15, 2023
@uatuko
(grpcxx) #7 - use a struct for rpc result type
a2f99ec
@uatuko uatuko closed this as completed in #8 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uatuko uatuko

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a struct for rpc result type uatuko/grpcxx
1 participant
@uatuko