feat: add new iOS versions #601
Conversation
| - regex: 'CFNetwork/.{0,100} Darwin/23\.6\.\d+' | ||
| os_replacement: 'iOS' | ||
| os_v1_replacement: '17' | ||
| os_v2_replacement: '6' |
There was a problem hiding this comment.
All those regexes are duplicates. We need one that extracts the os_v2 from the input string.
This is too many regexes to be added imho - cc @migueldemoura
There was a problem hiding this comment.
My concern is that we can't be certain that it will work always. It appears, according to the site I provided, Apple uses Darwin x.6 to denote every version that comes after iOS y.5. So now I even need to fix my PR for this.
I guess we can do something like CFNetwork/.{0,100} Darwin/23\.([1-5])\.\d+ for v17 and with 24 for v18 and then fall back to os_v1 only for other versions, but will it actually be more clean and readable?
There was a problem hiding this comment.
My worry is more for performance than cleanliness and readability. Given the above, we could use the regex you sent and match [1-6], and it'd work. Happy for you to update it the way you prefer, my only say is: the fewer regexes, the better!
regexes based on https://theapplewiki.com/wiki/Kernel#iOS/iPadOS