Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Coc Coc #247

Merged
merged 1 commit into from
May 22, 2017
Merged

Support for Coc Coc #247

merged 1 commit into from
May 22, 2017

Conversation

kokes
Copy link
Contributor

@kokes kokes commented May 20, 2017

Coc Coc is a fairly popular Vietnamese browser, it's based on Chrome. It used to contain a major and a minor version, it now includes a patch number as well (so I made it optional in my regex, to be backwards compatible).

I saw dozens of thousands of hits from this browser in our logs, but I took the test UA values from here.

(Tests passing on my laptop.)

@commenthol commenthol merged commit 1bf5f4b into ua-parser:master May 22, 2017
@commenthol
Copy link
Contributor

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants