Add HipChat, fix Slack, and a few browsers on Android. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ojaber Thanks for your PR. Maybe by accident you deleted a previous testcase. Can you please add this in again? Rebasing and squashing your changes to a single commit would be very nice. Thx. |
Fix Slack Desktop Client detection on Windows and Mac. Add support for HipChat on Mac and Windows. Fix Macthon and Crosswalk support on Android.
|
@commenthol Thanks for checking out the pull request :) |
|
Thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for HipChat on Windows and Mac.
Fix support for Slack on Mac.
Fix Maxthon and Crosswalk browsers which used to get recognized as Chrome Mobile on Android.