Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: migrate google visualization to maintained fork #2157

Conversation

ChristianMurphy
Copy link
Member

Checklist
Description of change

resolves uPortal-Project/uPortal-start#468

resolves uPortal-Project/uPortal-start#468

Co-authored-by: Julien Gribonvald <julien.gribonvald@gmail.com>
@jgribonvald
Copy link
Contributor

For me the change seems good, but someone tested it ? I didn't what on where are used these features (which portlets ?)

@ChristianMurphy
Copy link
Member Author

I ran a smoke test clicking through the admin views.
But as noted in the parent issue:

if you could take it for a test drive and ensure it works in your environment/preferred JDK, it would be appreciated. 🙇


I didn't what on where are used these features (which portlets ?)

It is used for a few chart jsp views in core https://github.com/Jasig/uPortal/search?q=visualization&unscoped_q=visualization

Copy link
Member

@bjagg bjagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bjagg bjagg merged commit a885243 into uPortal-Project:master Dec 14, 2020
@ChristianMurphy ChristianMurphy deleted the build/replace-google-visualization-datasource branch June 26, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uPortal fails with Java 8 version above 255
3 participants