This repository has been archived by the owner on May 4, 2022. It is now read-only.
WIP: fix: fail safe when portlet lacks title #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case where portlet.title undefined don't consider that portlet a filter match on title but don't exception out the whole filtering attempt
apetro
force-pushed
the
fail-safe-no-portlet-title
branch
from
a05ceb3 to
705b37a
Compare
ChristianMurphy
approved these changes
Mar 21, 2018
apetro
changed the title
The automatic |
|
🛎️ @apetro friendly reminder that this is close to being merge-able. |
thevoiceofzeke
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case where
portlet.titleundefineddon't consider that
portleta filter match ontitlebut also don't exception out the whole filtering attempt.
The app directory data should be good. This should never be a problem. But if the data is bad in this way, the consequence should be contained to the handling of that one bad record.
Contributor License Agreement adherence: