-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adguard French filter #379
Comments
|
I am going to keep this one open as a reminder in the future to evaluate the AdGuard list again. Currently the difference between Liste FR and AdGuard French is only ~40 filters. However, if this difference become significant, it may be worth to add the list to stock lists given that uBO benefits from AdGuard filters, while Liste FR constrains itself to only support ABP filter syntax. |
@Tiopik you know, you can add it by yourself? How-to: https://github.com/gorhill/uBlock/wiki/Filter-lists-from-around-the-web |
Adguard German filter has over 2.500 additional filters compared to Easylist Germany. |
@TonyTough You have a ready-to-use link for the AdGuard German list? |
https://filters.adtidy.org/extension/chromium/filters/6.txt On this site are links to all Adguard filter lists: |
I tried to check if these lists indeed differ by only 40 lines but what I found was two rather different lists. Wouldn't it be easier to add one manually in 'Filter lists' menu as mentioned by @gwarser. After all ublock will prevent doubling of filters if they happen to be the same. |
Looking into this again, I see AdGuard French is now a merge of AdGuard-specific filters + ListeFR, so I am tempted to replace the current ListeFR with AdGuard French since the latter uses uBO's Given this, any reason why replacing current ListeFR with Adguard French would be an issue? |
+1-3 hours delay after This may cause newbie users to drain (remove uBO and comeback to ABP or disable FR list in regional section). |
Well, the list support link will be that of AdGuard, https://github.com/AdguardTeam/AdguardFilters#adguard-filters, so when something is fixed there the instruction will be to force an update of Adguard French list. In the end AdGuard is willing to support not-invented-here filter syntax while ABP is unwilling to do so, so I rather go along with filter list maintainers who are not limiting themselves to just support ABP, it's uBO's users who benefit in the end. |
May I suggest to also look for the German list? DEU: EasyList Germany 9.615 benutzt aus 9.622 with EasyList Germany deactivated: 13503 - 3896 = 9607 So it seems that at the moment 8 filters are missing, but Adguard German filter has 3896 additional filters compared to EasyList Germany. |
|
Related issue: - uBlockOrigin/uBlock-issues#379 Related recent discussion: - uBlockOrigin/uAssets@529643b
Are there specific reasons why not to also replace EasyList Germany with AdGuard German filter? |
Somebody needs to come up with an assessment of why that would be desirable, and also evaluate that it does not interfere with uBO's own filters, there are a lot of |
Possible problems with some CSS filters:
General possible problems with the operation of script filters (without a risk assessment of whether two similar filters (one uBO and the other AdGuard) cause damage):
|
430 of those filters are for addefend/tisoomi sites, we already have our own "section" for those. |
Please add the Adguard French filter.
Merci.
The text was updated successfully, but these errors were encountered: