-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML filtering not working on codingdeft.com
#2656
Comments
codingdeft.com
Is this because page explicitly specifies }
// https://bugzilla.mozilla.org/show_bug.cgi?id=1426789
if ( headerValueFromName('content-disposition', headers) ) { return; }
const stream = request.stream =
browser.webRequest.filterResponseData(extras.requestId); It is. I'm 7 minutes too late. |
Somehow HTML filtering does not work on this link: Can anyone else reproduce? |
I can. E.g. this doesn't remove anything:
But works on a different page: |
Something to do with gorhill/uBlock@a3a80e3#diff-35c32f641b370cba4a5f06018c904c27241756164dfd317fa7c5698aec08c448R855 if ( charset === undefined ) { return; } Side-note: @stephenhawk8054 for anti-adb --
or |
at least in chrome => does it work for you for FF ? |
No, likely due to |
|
So why it is failing in FF then ? |
Still possible to have race condition. Use |
Anyway, is the issue reported in #2656 (comment) related to lack of |
I need to confirm, I can't do this right now, later today maybe. |
When uBO doesn't detect a |
I see, well the line I pulled out, suggested a bail-out situation like before. |
Can anyone use HTML filtering on this site: |
I can. What are you trying to remove? |
I was trying to remove admiral scripts inside while disabling current admiral domain blocking: ||muteknife.com^$badfilter
qtoptens.com##^script:has-text(engaged) It works at first time for me, but when refreshing without bypassing cache (F5) a few times, it doesn't remove the script any more. I figured out the cause, it's due to the service workers. When unregistering the service workers and use |
@gorhill Sorry, looks like HTML filtering is not working on The source looks like this <!DOCTYPE html>
<meta http-equiv="content-type" content="text/html; charset=euc-kr">
<html>
<head> |
Yes, that is not something uBO can handle. At 0.1% usage, not something I would work on -- I already declined work for Shift JIS (can't find issue anymore in tracker). |
Prerequisites
I tried to reproduce the issue when...
Description
When I use
in Firefox, it does not remove the inline script in the HTML source code.
Actually I cannot remove any tag in the source code using HTML filtering on this site.
A specific URL where the issue occurs.
https://www.codingdeft.com/posts/typescript-convert-enum-to-array/
Steps to Reproduce
codingdeft.com##^script
https://www.codingdeft.com/posts/typescript-convert-enum-to-array/
view-source:https://www.codingdeft.com/posts/typescript-convert-enum-to-array/
Expected behavior
Inline scripts are removed
Actual behavior
Inline scripts are not removed
uBO version
1.49.2
Browser name and version
Firefox 113.0.1
Operating System and version
Windows 10
The text was updated successfully, but these errors were encountered: