-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor issue: inconsistent casing in the "Block element..." menuitem in Firefox #1918
Comments
Actually I forgot another thing — in menuitems, Firefox uses the ellipsis character |
uBO is available on more than just Firefox, and other browsers do not necessarily follow this style. I will keep the style as is as this is how it's everywhere else in uBO. I will change |
Great! Yeah I'm aware the major browsers are inconsistent in casing, but still worth investigating. In addition to Firefox, the last time I checked Chrome on macOS used title case, presumably since that's how all of macOS' context menus are cased, but the last Windows build of Chrome I used had sentence case. Could make different strings for chrome vs. firefox but idk how well that works into your build system |
Related issue: - uBlockOrigin/uBlock-issues#1918
Ellipsis
|
Prerequisites
I tried to reproduce the issue when...
Description
Hi, this is a pretty small nitpick but still worth fixing. Firefox uses title case for all menus/menuitems, and sentence case for toolbar buttons. But uBlock Origin makes a menuitem with a sentence case label, so there's a mild sense of jank when using the context menu.
A specific URL where the issue occurs
https://github.com
Steps to Reproduce
Expected behavior
menuitem should say
Block Element...
Actual behavior
it says
Block element...
Configuration
The text was updated successfully, but these errors were encountered: