Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uBO 1.37 breaks at least some sites that use googletagmanager if specific filters in use #1671

Closed
8 tasks done
peace2000 opened this issue Jul 28, 2021 · 1 comment
Closed
8 tasks done
Labels
bug Something isn't working fixed issue has been addressed

Comments

@peace2000
Copy link
Member

peace2000 commented Jul 28, 2021

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

Related topic: https://www.reddit.com/r/uBlockOrigin/comments/osht47/prisjaktnu_is_a_blank_page/h6su51o/?context=3

When these two filters are present:

||googletagmanager.com/gtm.js$script,redirect-rule=googletagmanager.com/gtm.js

||googletagmanager.com/gtm.js$script

uBO will blank pages that use googletagmanager. I don't know how widespread this issue is, but at least one specific site cluster is affected.

This behaviour is not present if uBO 1.36.2 is in use, but in 1.37 blanking happens.

A specific URL where the issue occurs


https://hintaopas.fi
https://www.prisjakt.nu/
https://ledenicheur.fr/
https://prisjagt.dk/
https://www.prisjakt.no/
https://pricespy.co.nz/

Steps to Reproduce

  1. Use uBO 1.37
  2. Apply filters:

||googletagmanager.com/gtm.js$script,redirect-rule=googletagmanager.com/gtm.js

||googletagmanager.com/gtm.js$script

  1. Test the same with uBO 1.36.2

(4. Remember to disable uBO's internal unbreak filters)

Expected behavior

uBO would not blank the page when these filters are in use.

Actual behavior

Ubo blanks the page.

uBlock Origin version

1.37

Browser name and version

Firefox 90.0.2

Operating System and version

Windows 10

@peace2000 peace2000 changed the title Ubo 1.37 breaks sites that use googletagmanager Ubo 1.37 breaks at least some sites that use googletagmanager Jul 28, 2021
@peace2000 peace2000 changed the title Ubo 1.37 breaks at least some sites that use googletagmanager Ubo 1.37 breaks at least some sites that use googletagmanager if specific filters in use Jul 28, 2021
gorhill added a commit to gorhill/uBlock that referenced this issue Jul 28, 2021
@gorhill
Copy link
Member

gorhill commented Jul 28, 2021

I will publish a revision to stable channel given the number of sites found to be affected.

@uBlock-user uBlock-user added bug Something isn't working fixed issue has been addressed labels Jul 28, 2021
@peace2000 peace2000 changed the title Ubo 1.37 breaks at least some sites that use googletagmanager if specific filters in use uBO 1.37 breaks at least some sites that use googletagmanager if specific filters in use Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants