-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'$popup' not working #1659
Comments
I don't see a popup? |
Did you disable all other default lists ? |
@uBlock-user @gwarser |
@gwarser The popunder ads is not blocked by the |
Confusing, the opening comment states:
Then later in another comment:
So does it happen with the default settings/lists or does this requires to disable default filter lists? |
I'm sorry for confusion. All filters were disabled. Only user rules were activated. Thank you. |
uBO's onCreatedNavigationTarget() listener is not being called, so it appears to be a browser extension framework issue, and given that the issue is not reproducible with default filter lists, unlikely I will spend more time on investigating further for a workaround (if any). |
Thank you for your reply. I am working on a filter list in Korea. Popunder ads are used on so many sites. Script files associated with popunder are difficult to block because they vary from site to site. Some sites are lucky to be blocked, but advertisements are often exposed on most sites. Blocking URLs has limitations in blocking popunder ads. Using the $popunder rule is much more helpful. I hope that that can be resolved. Thank you. |
Note that I could not reproduce a In such case, uBO's onCreatedNavigationTarget() listener is not being called, which is necessary for uBO to find out which tab opened the popup and thus properly filter it -- I don't see how this can be solved safely without onCreatedNavigationTarget() working as expected. I am going to look again, ideally we would be able to find the minimal case so that we can file an issue with Chromium devs, but the page makes it difficult to investigate how this popup is being opened. |
The popunder ad runs a small square pop-up window at the bottom right; it opens a new window where the ad is displayed afterwards (see video). Please refer to the script file address where the popunder is activated. I hope it helps. video popunder script file |
Don't use |
It's because the popup is opened from an |
Related issue: - uBlockOrigin/uBlock-issues#1659 This commit introduces a workaround for missing onCreatedNavigationTarget() in Chromium.
Just disabling "uBlock filters" and toggling on the no-popups per-site switch was enough to reproduce the issue, no need to disable all the other lists, which allows to reproduce the issue without having to allow all ads and trackers. |
Oh, I see. I expected the $popunder to block the popunder ad. What I'm saying is that the popunder ad is being used on a lot of sites, and the script opens a new window after hiding the http referer property of header. I hope it helps. |
@nicekon can you try latest dev build https://github.com/gorhill/uBlock/releases? It look fixed to me. |
Thank you for answering. Unfortunately, I still see pop-up ads. |
|
I looked into this a bit more and this is not something which can be fixed in uBO, this has to be fixed in Chromium. |
Prerequisites
I tried to reproduce the issue when...
URL(s) where the issue occurs
https://dood.watch/d/bnyc4jrdf5sx
Describe the issue
*$popunder,domain=dood.watch
popunder ad is showing but rules not working
Screenshot(s)
No response
uBlock Origin version
1.36.2
Browser name and version
Chrome 91.0.4472.114
Settings
Activate only user filters
Notes
No response
The text was updated successfully, but these errors were encountered: