Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Countering a removeparam filter causes page-redirect problem #1626

Closed
5 of 8 tasks
Yuki2718 opened this issue Jun 12, 2021 · 5 comments
Closed
5 of 8 tasks

Countering a removeparam filter causes page-redirect problem #1626

Yuki2718 opened this issue Jun 12, 2021 · 5 comments
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed

Comments

@Yuki2718
Copy link

Yuki2718 commented Jun 12, 2021

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported
  • The issue is not present after wholly disabling uBlock Origin ("uBO") in the browser
    • If the issue is still present after wholly disabling uBO in the browser, then the issue is unrelated to uBO
  • I tried to reproduce the issue when...
    • uBO is the only extension
    • uBO with default lists/settings
    • using a new, unmodified browser profile
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

Making an exception for a removeparam filter which breaks redirecting causes another issue of page-redirect (apparently only on uBO).

A specific URL where the issue occurs

https://toptechtalk.xyz/?utm_source=socialmedia_uUod
(visit http://turkdebrid.site/api1/?page=create&ads=zshort.io)

Steps to Reproduce

  1. Add AdGuard URL Tracking filter: https://filters.adtidy.org/extension/ublock/filters/17.txt
  2. Add
@@$removeparam=utm_source,domain=toptechtalk.xyz
@@||toptechtalk.xyz/?utm_source=$removeparam=utm_source,badfilter

to My filters - without this you'll be moved to homepage than the intended destination.
3. Visit http://turkdebrid.site/api1/?page=create&ads=zshort.io

Screenshot

toptechtalk

Expected behavior:

You'll be redirected to https://toptechtalk.xyz/is-it-profitable-to-start-an-e-commerce-business-and-earn-money/. This occurs if you unsubscribe AdGuard URL Tracking filter. There's no other parameter involved as far as the logs go.

Actual behavior:

Described

Your environment

  • uBlock Origin version: v1.35.2/v1.35.3rc1
  • Browser Name and version: Firefox 89.0
  • Operating System and version: Windows 10
@Yuki2718 Yuki2718 changed the title Countering a removeparam filter causes pgae-redirect problem Countering a removeparam filter causes page-redirect problem Jun 12, 2021
@Yuki2718
Copy link
Author

I added exception to AdGuard URL Tracking filter so please also add @@||toptechtalk.xyz/?utm_source=$removeparam=utm_source,badfilter

@gwarser
Copy link

gwarser commented Jun 12, 2021

Just these two will be enough?

$removeparam=utm_source
@@$removeparam=utm_source,domain=toptechtalk.xyz

@Yuki2718
Copy link
Author

Yuki2718 commented Jun 12, 2021

Just these two will be enough?

Yup, reproduced. Commenting out the above filter fixes the problem.

gorhill added a commit to gorhill/uBlock that referenced this issue Jun 12, 2021
@gorhill
Copy link
Member

gorhill commented Jun 12, 2021

Looks like Firefox does not validate whether the returned redirectUrl is the same as the current URL, while Chromium does. So the fix is for uBO to do that check.

@gwarser gwarser added bug Something isn't working Firefox specific to Firefox fixed issue has been addressed labels Jun 12, 2021
@gwarser
Copy link

gwarser commented Jun 12, 2021

Exception is not working at all now? Sorry, caused by different filter. All is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firefox specific to Firefox fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants