Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Easylist Cookie a default list #1573

Closed
ryanbr opened this issue Apr 29, 2021 · 5 comments
Closed

Making Easylist Cookie a default list #1573

ryanbr opened this issue Apr 29, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@ryanbr
Copy link

ryanbr commented Apr 29, 2021

With Vivaldi blocking consent/cookie/gdpr warnings by default, should we also follow suit and block consent messages by default in uBO.

https://www.forbes.com/sites/barrycollins/2021/04/29/vivaldi-browser-kills-irritating-cookie-pop-ups/
https://www.zdnet.com/article/vivaldi-browser-tries-to-tame-website-cookie-consent-forms/
https://www.theregister.com/2021/04/29/vivaldi_3_8/

Has been discussions to make it default in Brave, and whether uBO would block consent messages by default.

I've created a seperate uBO list options for easylist/easylist@84d2370 (to fix sites that break scrollbars etc) Which we can bring over any consent-related filters from uBO annoyances

@uBlock-user
Copy link
Contributor

Sounds like #1111

@ryanbr
Copy link
Author

ryanbr commented Apr 30, 2021

Annoyances by default might be stretch, just consent messages here

@Yuki2718
Copy link

Yuki2718 commented Apr 30, 2021

Frankly, cookie lists are false-positive prone, enabling it by default will keep uBO from being install-and-forget solution for everyone. Nevertheless nice to see you've added the sublist for uBO.

@uBlock-user uBlock-user added the enhancement New feature or request label Apr 30, 2021
@ryanbr
Copy link
Author

ryanbr commented Apr 30, 2021

Closing, we'll let the list mature a bit more. But given Vivaldi has defaulted this, we can see how many false positives (or if they are reported)

@ryanbr ryanbr closed this as completed Apr 30, 2021
@krystian3w
Copy link

krystian3w commented May 20, 2021

A few pop-ups may need use watch-attr = so generated 1 second blinks before hide Cookies/GDRP:

hrkgame.com##.dimmable, .dimmed:style(overflow: auto !important;)
hrkgame.com##.modals.dimmer > .gdpr.ui:style(visibility: hidden !important;)
hrkgame.com##.modals.dimmer > .gdpr.visible:upward(1):watch-attr([class])

Or these alpine combinations if we prefere pure CSS method detection (still possible see blinks):

hrkgame.com##.dimmable, .dimmed:style(overflow: auto !important;)
hrkgame.com##html > body .modals.dimmer > .gdpr.visible:upward(1)
hrkgame.com##html:root > body .modals.dimmer > .gdpr.hidden:upward(1):style(display: flex !important;)

CSS + upward base on Specificity and need uBO 1.30+ (watch-attr only need 1.20+):

obraz :root enforce display: flex for pop-ups after found .gdpr.hidden classes

Problem on hrkgame generate pop-up in settings about enable 2FA, simple filter don't allow enable/disable 2FA: AdguardTeam/AdguardFilters#69498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants