-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AdGuard's noopvmap-1.0 equivalent as a redirect resource #1425
Comments
Basically:
|
Of note, AG Base has 2 filters redirecting to this. They excludes uBO.
|
They also have noopvast, what does that help fix ? |
Related issue: - uBlockOrigin/uBlock-issues#1425 The resource content is a copy/paste of AdGuard's code: - https://github.com/AdguardTeam/Scriptlets/blob/bc5eec198903856413e3e114a1d636c34146173d/src/redirects/static-redirects.yml#L134
I could not test that it works, feedback about this is welcome. |
on |
Related issue: - uBlockOrigin/uBlock-issues#1425 The resource content is a copy/paste of AdGuard's code: - https://github.com/AdguardTeam/Scriptlets/blob/bc5eec198903856413e3e114a1d636c34146173d/src/redirects/static-redirects.yml#L134 Related commit: - gorhill/uBlock@1669d12 Co-authored-by: Raymond Hill <rhill@raymondhill.net>
On |
Fully fixed with gorhill/uBlock@59a9a43 |
Prerequisites
Description
AdGuard Japanese addressed AdguardTeam/AdguardFilters#70829 by redirecting XHR to noopvmap-1.0, which indeed works. uBO doesn't have a counterpart so only way to fix this is allowing the request - redirecting to other resources such as noop.txt doesn't work. To be fair, allowing the request doesn't bring actual ads and uBO version of AG Japanese doesn't include the redirect filter so it's not a serious problem but a suggestion.
A specific URL where the issue occurs
https://tver.jp/corner/f0064327
(geo-locked)Steps to Reproduce
Expected behavior:
AG Japanese' redirect works on uBO too.
Actual behavior:
Doesn't work.
Your environment
Note
I'll remove the whitelist from Unbreak. If this suggestion is accepted and the resource is added, I can make PR on AG for them to include uBO for the target of the redirect filter.
Related:
#1366 (comment)
AdguardTeam/Scriptlets#52
The text was updated successfully, but these errors were encountered: