Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Uses vAPI to pass information from contentscript-start.js to contentscript-end.js #365

Closed
gorhill opened this issue Nov 16, 2014 · 2 comments

Comments

@gorhill
Copy link
Contributor

gorhill commented Nov 16, 2014

A while ago I had concluded (after trying to make it work) content scripts lived in their own world, with their own global context. The vAPI from @Deathamns proves me wrong: all content scripts (for a same page or frame) share the same global context.

Looks like something else was going on at the time I checked, probably I was using a silly test case.

So this means the little "hack" I currently use to pass exception filters from contentscript-start to contentscript-end can be removed, and I will just use the vAPI object to pass the information, hence skipping the overhead of encoding/decoding the exceptions into a style tag attribute.

@gorhill
Copy link
Contributor Author

gorhill commented Nov 16, 2014

Could remove more code/overhead than originally thought.

@gorhill
Copy link
Contributor Author

gorhill commented Nov 26, 2014

Regression bug fixed with f141d6f. Test case: all hashtags where hidden in https://twitter.com

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant