Map Windows time zone IDs to their IANA equivalent

[marcelstoer]

Attempt to fix #186.

@u01jmg3 @jasonheffner WDYT?

[u01jmg3]

I think you're on the right track albeit with a little tidy up. I would also double check PHP understands every conversion e.g. 'Etc/GMT+11'.

[marcelstoer]

albeit with a little tidy up

Can you be more specific? I rarely code in PHP.

I asked myself whether it would be more efficient to first check for a Windows zone id in a TZID string before calling str_replace. Something like

foreach($needles as $needle){
  if (strpos($haystack, $needle) !== false) {
    return str_replace(...);
  }
}

However, AFAIU this won't make much difference anyhow.

double check PHP understands every conversion e.g. 'Etc/GMT+11'

It's my understanding that it does - you've already got that in your code: https://github.com/u01jmg3/ics-parser/blob/master/src/ICal/ICal.php#L1959. In fact, I started off by copying that CLDR array and then replaced the keys.

[marcelstoer]

@u01jmg3 We have been using it like this for 2w w/o issues. If you're still interested in accepting this PR then I would need guidance as per my previous comment. Otherwise I'll close it.

[u01jmg3]

Thanks for the info. Keep it open and I shall take a look as soon as I have some time.