Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using UTC timestamps when comparing dates #177

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

petermillgram
Copy link
Contributor

@petermillgram petermillgram commented Apr 4, 2018

Resolves #176

Makes date comparisons more dependable by changing the values of {DTSTART|DTEND|RECURRENCE-ID}_array[2].

Makes date comparisons more dependable by changing the values of
{DTSTART|DTEND|RECURRENCE-ID}_array[2].
@petermillgram
Copy link
Contributor Author

petermillgram commented Apr 4, 2018

This is what fixed the issue for me. But I keep wondering why do we want iCalDateToUnixTimestamp() to return something that is not a Unix timestamp.

@u01jmg3 u01jmg3 self-requested a review April 27, 2018 12:51
@u01jmg3 u01jmg3 added this to the v2.x.x milestone Apr 27, 2018
@u01jmg3 u01jmg3 merged commit 19931c8 into u01jmg3:master Apr 27, 2018
@petermillgram petermillgram deleted the petermillgram-patch-1 branch April 30, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Past events returned by eventsFromRange('now')
2 participants