Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable string truncation warning #214

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

NathanMOlson
Copy link
Contributor

This "fixes" a compile error experiences on Linux with GCC 11.4.0.

@RobMeades
Copy link
Contributor

Hi, thanks for this: I guess the truncation warning is occurring somewhere other than the ones that we already tried to shut up in 1f93918 and bc8e776?

@NathanMOlson
Copy link
Contributor Author

Error is at ubxlib/port/platform/linux/src/u_port_uart.c:394:13

@RobMeades
Copy link
Contributor

Interestingly, I changed that very line yesterday, see 208ef1b, so it could be a pointer to a real problem in this case. Don't suppose you'd be willing to pull master from here and see if that happens to have fixed it would you? If it hasn't, I'm also very happy to take your PR as we haven't been able to switch-up to the latest GCC as it messes up something else, and I'm finding this particular GCC warning quite annoying.

@NathanMOlson
Copy link
Contributor Author

@RobMeades I've pulled your latest changes from master, and it still fails to compile without 06a0869. With that and b08e5ab, I've achieved "hello world" with my M9 receiver.

@RobMeades
Copy link
Contributor

Thanks for checking, and good catch on the b08e5ab, we should add a GNSS device connected via USB in our test system to test that case (only have I2C, SPI and UART today). I will pull your PR locally to run through testing, then merge.

@RobMeades RobMeades merged commit 1bde1d2 into u-blox:master Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants